Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for KSqlDB session variables #544

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

nachomdo
Copy link
Contributor

@nachomdo nachomdo commented Oct 4, 2022

  • Please check if the PR fulfills these requirements
  • The commit messages are descriptive
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature - KSqlDB Session Variables support to enable parametric artefacts  #545

  • What is the current behavior? (You can also link to an open issue here)
    KSqlDB Session Vars are not supported

  • What is the new behavior (if this is a feature change)?
    Allows to specify session vars that can be interpolated in parametric KSqlDB artefacts

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No breaking changes. Session vars can be safely omitted from the topology descriptor file

  • Other information:
    Upgrade of KSqlDB container and API client to versions that support the definition of session vars.
    Upgrade of Zookeeper client due to conflicts with Netty dependencies

@purbon
Copy link
Collaborator

purbon commented Oct 10, 2022

I like it, thanks a lot @nachomdo for your contribution. I'm in the process of merging this in, it will be available in the next upcoming release.

@purbon purbon self-requested a review October 10, 2022 13:37
@purbon purbon merged commit da33be1 into kafka-ops:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants