Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Conditional for loading oem #85

Merged
merged 1 commit into from
Mar 9, 2023
Merged

✨ Conditional for loading oem #85

merged 1 commit into from
Mar 9, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Mar 9, 2023

If we cannot get the label then disable mounting oem

Fixes: kairos-io/kairos#920

If we cannot get the label then disable mounting oem

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka Itxaka requested a review from mudler March 9, 2023 08:24
@Itxaka Itxaka enabled auto-merge (squash) March 9, 2023 08:24
@Itxaka Itxaka disabled auto-merge March 9, 2023 09:05
@Itxaka
Copy link
Member Author

Itxaka commented Mar 9, 2023

Im still not sure about this, Im wondering that if oem dissapears the DAG may break as it cant find the dep of oem, even if its weak.

Needs more testing

@mudler
Copy link
Member

mudler commented Mar 9, 2023

EnableIf makes the job show in the dag nevertheless, but it won't run - so it should be fine and not break any dependency

Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Itxaka Itxaka merged commit 88a2ca8 into master Mar 9, 2023
@Itxaka Itxaka deleted the conditional_oem branch March 9, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some actions should have a condition
2 participants