🐛 Improve network stage #1062
Merged
🐛 Improve network stage #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First disable NetworkManager and wicked - Then enable systemd services for network and resolv - Then remove and link /etc/resolv.conf This fixes a case in which systemd-networkd could be enabled before wicked is disabled and because network is linked to wicked it would fail to enable systemd-networkd properly during initramfs. Also adds a check before removing the resolv.conf, to skip it if it doesnt exist. Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
✅ Deploy Preview for kairos-io canceled.
|
mudler
approved these changes
Mar 8, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 22.79% 22.79%
=======================================
Files 22 22
Lines 1610 1610
=======================================
Hits 367 367
Misses 1179 1179
Partials 64 64 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Itxaka
added a commit
to Itxaka/kairos
that referenced
this pull request
Mar 9, 2023
- First disable NetworkManager and wicked - Then enable systemd services for network and resolv - Then remove and link /etc/resolv.conf This fixes a case in which systemd-networkd could be enabled before wicked is disabled and because network is linked to wicked it would fail to enable systemd-networkd properly during initramfs. Also adds a check before removing the resolv.conf, to skip it if it doesnt exist. Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com> Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes a case in which systemd-networkd could be enabled before wicked is disabled and because network is linked to wicked it would fail to enable systemd-networkd properly during initramfs.
Also adds a check before removing the resolv.conf, to skip it if it doesnt exist.
Found by immucore running the initramfs as it spits out the errors into the log and we can see them more easily
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #