Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass VERSION flag including v2 in path #1290

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

mauromorales
Copy link
Member

@mauromorales mauromorales commented Apr 13, 2023

What this PR does / why we need it:
Since the code is built on v2, the VERSION to build it needs to also have v2 in the path

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
fixes #1287

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit 8b5c072
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/64380d70a1d3da0008fda72c

@mauromorales mauromorales requested a review from a team April 13, 2023 14:11
@mauromorales mauromorales self-assigned this Apr 13, 2023
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh good catch!

Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Good catch!

@mudler mudler merged commit 39c7824 into master Apr 13, 2023
@mudler mudler deleted the 1287-set-version-in-v2 branch April 13, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 Kairos agent version in v2 shows as 0.0.0
3 participants