🐛 Fix restoring machine-id on reboot #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was missing a check for openrc on the restoring machine-id so it was restored twice and the second was picking up a new machine-id generated by dbus This worked on openrc systems as the paths to save and restore were correct and the save overwrote the generation but on systemd it was a newly generated machine-id that we are not saving thus it never matched. Alos drops a duplicated metadata call Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
mauromorales
approved these changes
Jun 21, 2023
jimmykarily
approved these changes
Jun 21, 2023
Itxaka
added a commit
to Itxaka/kairos
that referenced
this pull request
Jun 21, 2023
(cherry picked from commit 2ab366b)
mauromorales
pushed a commit
that referenced
this pull request
Jun 21, 2023
mauromorales
pushed a commit
that referenced
this pull request
Jun 21, 2023
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
mauromorales
pushed a commit
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was missing a check for openrc on the restoring machine-id so it was restored twice and the second was picking up a new machine-id generated by dbus
This worked on openrc systems as the paths to save and restore were correct and the save overwrote the generation but on systemd it was a newly generated machine-id that we are not saving thus it never matched.
Alos drops a duplicated metadata call
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #