Build provider in kairos and bring tests #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Itxaka
force-pushed
the
provider-kairos
branch
2 times, most recently
from
7f9cb68
to
e5442b1
Compare
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Add them at the top for future use, manually re-run OSRELEASE under provider iso Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
They are already set at the root level Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Itxaka
commented
Jul 11, 2023
| @@ -211,13 +230,14 @@ func startVM() (context.Context, VM) { | |||
| return ctx, vm | |||
| } | |||
|
|
|||
| func isFlavor(flavor string) bool { | |||
| return strings.Contains(os.Getenv("FLAVOR"), flavor) | |||
| func isFlavor(vm VM, flavor string) bool { | |||
There was a problem hiding this comment.
this now doesn't depend on user setting the FLAVOR var, which made no sense to me.
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
So we reboot to the active system after install Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
|
all jobs passed under https://github.com/kairos-io/kairos/actions/runs/5528778626/jobs/10086510302 moving them now to master only |
.github/workflows/image.yaml
Outdated
| git fetch --prune --unshallow | ||
| - name: setup-docker | ||
| uses: docker-practice/actions-setup-docker@master | ||
| - name: Release space from worker |
There was a problem hiding this comment.
not a big deal, but should we move together with the other Release space?
There was a problem hiding this comment.
woops, didnt even noticed
mauromorales
previously approved these changes
Jul 12, 2023
Co-authored-by: Mauro Morales <contact@mauromorales.com> Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itxaka itxaka.garcia@spectrocloud.com
What this PR does / why we need it:
Brings the testing of provider-kairos into kairos CI.
This only deals with x86 testing as there is no other tests rather than building an iso/image for arm64.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1557