🤖 Fix+move image size test #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the image size check into the acceptance tests. Fixes to it takes into account the new image sizes. Before we were overriding the image sizes with the elemental config yaml and setting them to 3000 but now if not set via cloud config they will get set to the default in kairos-agent which is 3072 and its a constant for all default images. Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
mauromorales
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the image size check into the acceptance tests. Fixes to it takes into account the new image sizes. Before we were overriding the image sizes with the elemental config yaml and setting them to 3000 but now if not set via cloud config they will get set to the default in kairos-agent which is 3072 and its a constant for all default images.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #