🤖 Fix provider tests #1674
Merged
🤖 Fix provider tests #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test that is no longer valid and in any case should be moved to acceptance tests and the other that need an extra key in the config to auto reboot Signed-off-by: Itxaka <itxaka@kairos.io>
|
only affect provider tests which are in the master pipeline, tested over https://github.com/kairos-io/kairos/actions/runs/5739532482 with green results, merging directly to unblock master pipeline |
jimmykarily
reviewed
Aug 3, 2023
| @@ -72,7 +72,8 @@ var _ = Describe("kairos qr code install", Label("provider", "provider-qrcode-in | |||
| Expect(err).ToNot(HaveOccurred(), device) | |||
|
|
|||
| By("registering with a screenshot") | |||
| err = register("fatal", fileName, "./assets/config.yaml", strings.TrimSpace(device), true) | |||
| // pass a config that auto reboots after install as we cannot know when the machine has finished | |||
| err = register("fatal", fileName, "./assets/config_with_reboot.yaml", strings.TrimSpace(device), true) | |||
There was a problem hiding this comment.
The file name above has a typo: _rebot vs reboot. This file here doesn't exist. How did this work?
There was a problem hiding this comment.
It worked on my branch where I had moment of brilliance and was able to spell reboot .
No wonder it's still failing. You just saved me a couple of hours of troubleshooting lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test that is no longer valid and in any case should be moved to acceptance tests and the other that need an extra key in the config to auto reboot
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #