Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Add raw image target to earthly #1675

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Aug 3, 2023

Useful to emulate what osbuilder does to build cloud images for local testing

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Useful to emulate what osbuilder does to build cloud images for local
testing

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team August 3, 2023 08:55
@Itxaka
Copy link
Member Author

Itxaka commented Aug 3, 2023

Side effect of #1664 and having to test the cloud images with no access to a k8s cluster

mauromorales
mauromorales previously approved these changes Aug 3, 2023
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Earthfile Show resolved Hide resolved
jimmykarily
jimmykarily previously approved these changes Aug 3, 2023
Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka dismissed stale reviews from jimmykarily and mauromorales via 658836d August 3, 2023 11:56
@Itxaka
Copy link
Member Author

Itxaka commented Aug 3, 2023

cencelled the jobs as nothing is affected by this

@Itxaka Itxaka merged commit 7b7863d into kairos-io:master Aug 3, 2023
6 of 17 checks passed
@Itxaka Itxaka deleted the raw_image_earthly branch August 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants