Build and release multi arch framework images #2024
Merged
+38
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
jimmykarily
reviewed
Nov 24, 2023
jimmykarily
reviewed
Nov 24, 2023
| COPY +version/VERSION ./ | ||
| ARG VERSION=$(cat VERSION) | ||
|
|
||
| ARG _IMG="$IMAGE_REPOSITORY_ORG/framework:${VERSION}_${FRAMEWORK_FLAVOR}" | ||
| IF [ "$VERSION" ~= ".*dirty.*" ] | ||
| ARG FRAMEWORK_VERSION=master |
There was a problem hiding this comment.
yeah right now I thought there would be only 2 options, master or a release tag ... but indeed lets evaluate if there's a better way to do it
jimmykarily
approved these changes
Nov 24, 2023
|
late to this, but pretty cool @mauromorales ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we only release amd64 framework images. Making them multi arch allows us to take advantage of the pre-built frameworks in arm. this will be particularly useful for the extraction of the earthly logic into dockerfiles related to #1897