Improve test coverage

kaitoy · May 10, 2020 · 1b6c01f · 1b6c01f
1 parent e20bc3a
commit 1b6c01f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/pcap4j-packettest/src/test/java/org/pcap4j/test/packet/TlsPacketTest.java b/pcap4j-packettest/src/test/java/org/pcap4j/test/packet/TlsPacketTest.java
@@ -16,6 +16,7 @@
 import org.pcap4j.packet.tls.extensions.UnimplementedTlsExtension;
 import org.pcap4j.packet.tls.extensions.keyshare.KeyShareEntry;
 import org.pcap4j.packet.tls.extensions.keyshare.ServerKeyShareExtension;
+import org.pcap4j.packet.tls.records.AlertRecord;
 import org.pcap4j.packet.tls.records.ApplicationDataRecord;
 import org.pcap4j.packet.tls.records.HandshakeRecord;
 import org.pcap4j.packet.tls.records.TlsRecord;
@@ -76,6 +77,8 @@ public TlsPacketTest() {
 
         TlsRecord dataRecord = new ApplicationDataRecord(new byte[]{1, 2, 3, 4, 5});
 
+        TlsRecord alertRecord = new AlertRecord(AlertLevel.WARNING, AlertDescription.unknown_ca);
+
         b.contentType(ContentType.HANDSHAKE)
                 .version(TlsVersion.TLS_1_2)
                 .recordLength((short) 95)
@@ -84,7 +87,12 @@ public TlsPacketTest() {
                         .version(TlsVersion.TLS_1_2)
                         .contentType(ContentType.APPLICATION_DATA)
                         .recordLength((short) 5)
-                        .record(dataRecord));
+                        .record(dataRecord)
+                        .payloadBuilder(new TlsPacket.Builder()
+                                .version(TlsVersion.TLS_1_2)
+                                .contentType(ContentType.ALERT)
+                                .recordLength((short) 2)
+                                .record(alertRecord)));
 
         this.packet = b.build();
     }

diff --git a/pcap4j-packettest/src/test/resources/TlsPacketTest.log b/pcap4j-packettest/src/test/resources/TlsPacketTest.log
@@ -12,4 +12,8 @@
 [TLS Header (10 bytes)]
   Version: 771 (TLS 1.2)
   Type: 23 (Application Data)
-  Encrypted data: [5 bytes]
+  Encrypted data: [5 bytes]
+[TLS Header (7 bytes)]
+  Version: 771 (TLS 1.2)
+  Type: 21 (Alert)
+  Alert [level: warning, description: unknown_ca]
diff --git a/pcap4j-packettest/src/test/resources/TlsPacketTest.obj b/pcap4j-packettest/src/test/resources/TlsPacketTest.obj
diff --git a/pcap4j-packettest/src/test/resources/TlsPacketTest.pcap b/pcap4j-packettest/src/test/resources/TlsPacketTest.pcap