Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Got multiple bindings ... but non-list value map-merge #39

Closed
glebm opened this issue Feb 3, 2019 · 1 comment · Fixed by #40
Closed

Bug: Got multiple bindings ... but non-list value map-merge #39

glebm opened this issue Feb 3, 2019 · 1 comment · Fixed by #40

Comments

@glebm
Copy link
Contributor

glebm commented Feb 3, 2019

Input

$map: () !default;
$map: map-merge((a: 1, b: 2),
  $map
);

@each $k, $v in $map {
  @debug "#{$k} #{$v}";
}

Error:

thread 'main' panicked at 'Got multiple bindings ["k", "v"], but non-list value map-merge', src/variablescope.rs:47:13

It works if I change:

$map: map-merge((a: 1, b: 2),
  $map
);

to:

$map: map-merge((a: 1, b: 2),
  $map);
@kaj
Copy link
Owner

kaj commented Feb 3, 2019

Hm, sounds like the call isn't recognized as a call in the case with a newline after the second argument. I'll look into it (unless you're faster).

glebm added a commit to glebm/rsass that referenced this issue Feb 3, 2019
@kaj kaj closed this as completed in #40 Feb 3, 2019
kaj added a commit that referenced this issue Feb 10, 2019
Sass-spec reports 1645 of 3440 tests for sass 3.6 passed.

* Improve support for `transparent`.
* PR #45 from @glebm: Automatically update passing / failing tests
  Hardkoded skiplists in spectest.rs is cleared apart for tests where
  rsass panics.
* Issue 43: Normalize newlines in tests.
* PR #44 from @glebm: Update to Rust 2018 Edition, Rust v1.31.0+
* Issue #39, PR #40 from @glebm: Parser CallArgs: Allow trailing
  spacelike sans ","
* Issue #32: Make the selectors module pub.
* Issue #34, PR #35 from @glebm: Accessing an undefined variable is an error.
* Allow input starting with UTF-8 U+FEFF BOM.
* Target sass spec version 3.6.

Thanks to contributors @glebm, @maxbrunsfeld and @sunjay for code and
suggestions.
kaj added a commit that referenced this issue Feb 10, 2019
Sass-spec reports 1645 of 3440 tests for sass 3.6 passed.

* Improve support for `transparent`.
* PR #45 from @glebm: Automatically update passing / failing tests
  Hardkoded skiplists in spectest.rs is cleared apart for tests where
  rsass panics.
* Issue 43: Normalize newlines in tests.
* PR #44 from @glebm: Update to Rust 2018 Edition, Rust v1.31.0+
* Issue #39, PR #40 from @glebm: Parser CallArgs: Allow trailing
  spacelike sans ","
* Issue #32: Make the selectors module pub.
* Issue #34, PR #35 from @glebm: Accessing an undefined variable is an error.
* Allow input starting with UTF-8 U+FEFF BOM.
* Target sass spec version 3.6.

Thanks to contributors @glebm, @maxbrunsfeld and @sunjay for code and
suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants