Preparatory work for splitting Value #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail due to rustfmt issue, see #11 |
|
Tests are passing now :) |
|
Hm. At the moment the split between the |
|
There are a lot of things in I'm not actually sure where these things should live, as it seems sensible to reuse them for both the CSS and SASS ASTs, so I've just left them in the |
jnicklas
force-pushed
the
sass-mod
branch
2 times, most recently
from
aca52ca
to
5b5c453
Compare
|
Sorry for the delay ... Merging now. |
kaj
added a commit
that referenced
this pull request
Oct 15, 2017
A default run of sass-spec found 1163 of 3331 tests passing (or 1227 of 6086 when claiming to be libsass). Changes since version 0.3.4 includes: * Implemented bracketed lists. * Support CSS3 pseudo elements * Added functions: unitless, content-exists, zip, is-bracketed, join. * Update the nom parser library to 3.2. * PR #13 Split of css values from sass values. * PR #10 Preparatory work for splitting Value * PR #7 Extract parser into separate module * PR #8 Extract som modules from lib.rs * Pin rustfmt to 0.8.4, to avoid surprising formatting changes. * PR #6 Don't require a git plugin for the check-spec. Thank You to Jonas Nicklas for many contributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly moves some code around to make the next steps easier.