Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file handling. #132

Merged
merged 3 commits into from
Mar 12, 2022
Merged

Refactor file handling. #132

merged 3 commits into from
Mar 12, 2022

Conversation

kaj
Copy link
Owner

@kaj kaj commented Mar 12, 2022 •
edited
Loading

Breaking changes

  • The functions parse_scss_file and parse_scss_path is removed. Use SourceFile (maybe from a FileContext) instead.
  • Some API changes (mayinly using SourceFile as return type) in FileContext and FsF ileContext.

Improvements

  • Refactor source file handling. Instead of creating new FileContexts wrapping the original for each file for searching for local paths in that file, use the SourceName of the containing file to find local paths.

@kaj kaj force-pushed the refactor-files branch 2 times, most recently from 31612ad to b5aad7b Compare March 12, 2022 23:16
@kaj kaj merged commit 79fa0d8 into master Mar 12, 2022
@kaj kaj deleted the refactor-files branch March 12, 2022 23:42
kaj added a commit that referenced this pull request Mar 23, 2022
@kaj
Release 0.24.0
5f2c025 
Released 2022-03-23.
Progress: 4013 of 6478 tests passed in dart-sass compatibility mode.

### Breaking changes

* The functions `parse_scss_file` and `parse_scss_path` is removed.
  Use `SourceFile` (maybe from a `FileContext`) instead (PR #132).
* Some API changes (mayinly using `SourceFile` as return type) in
  `FileContext` and `FsF ileContext` (PR #132).
* `Scope::get` now takes an `&Name` rather than an `&str` for the
  variable name.
* `sass::Value::Variable` now has a source position.
* `sass::Item` and `css::BodyItem` got new alternatives for custom
  properties (PR #134).
* Some changes in the `Error` type to facilitate positions.

### Improvements

* Basic support for `meta.load-css` mixin (PR #131).
* Improved `calc` and `clamp` handling (PR #133).
* Support custom properties (PR #134).
* Refactor source file handling.  Instead of creating new FileContexts
  wrapping the original for each file for searching for local paths in
  that file, use the SourceName of the containing file to find local
  paths (PR #132).
* Detect `@import` loops.
* Report undefined variable / module errors better.
* Update color formatting.  Sass-spec changed how it decides what
  format to show a color in (PR #135).
* Enable clippy in CI and fix some things it complained about (PR #128).
* Update sass-spec test suite to 2022-03-17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kaj