Support user-defined functions in rust #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enough to at least define a global variable before parsing the file.
The ergonomics still sucks, though.
kaj
force-pushed
the
feature/rust-functions
branch
from
e859a61
to
9264267
Compare
kaj
added a commit
that referenced
this pull request
May 6, 2017
A default run of sass-spec found 1039 of 3299 tests passing (or 1097 of 6054 when claiming to be libsass). Changes since version 0.2.0 includes: * PR #4: Support application-defined functions in rust. * Equal strings are equal even if the quoting differs (e.g. foo == "foo"). * Improved value parsing in many ways. * Implemened numeric rounding rules to match libsass default. * Improved handling of null values. * Fix some minor output formatting issues. * Handle arguments to pseudo-selectors (which are themselfs selectors) properly. * Support for rust 1.14 is dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A program using rsass as a library should be able to define functions in rust. An example use-case is that ructe should be able to define a function to get the uniquified url of a static file.
This means that
Scopes and theValuetype needs to be public.