Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.2.0 #6

Merged
merged 18 commits into from
Dec 5, 2019
Merged

v0.2.0 #6

merged 18 commits into from
Dec 5, 2019

Conversation

yjchoe
Copy link
Contributor

@yjchoe yjchoe commented Nov 28, 2019

Updates corresponding to our arXiv paper submission.

  • Refactored & updated Word2word class, which now includes make() and load() functionalities for building and loading from custom bilingual lexicons.
  • Better tokenizers & larger cutoff values used.
  • Optimized make() function using multiprocessing.
  • More command-line options, including a custom saving directory (Linux: Permission denied error #4).

kimdwkimdw
kimdwkimdw approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@kimdwkimdw kimdwkimdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kyubyong
Kyubyong approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@Kyubyong Kyubyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@yjchoe yjchoe merged commit 8321beb into master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimdwkimdw kimdwkimdw kimdwkimdw approved these changes

@Kyubyong Kyubyong Kyubyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjchoe @kimdwkimdw @Kyubyong