Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing snapshot #4

Closed
wants to merge 1 commit into from

Conversation

antoniocfdsilva
Copy link

No description provided.

@kakashidinho
Copy link
Owner

Thanks for the PR. I will take a look later when I have time.

@antoniocfdsilva
Copy link
Author

Thanks for the PR. I will take a look later when I have time.

Any news about this PR?

@kakashidinho
Copy link
Owner

Thanks for the PR. I will take a look later when I have time.

Any news about this PR?

Thanks for the PR again. To be honest, I have updated the framework to make it cross platform across iOS and macOS. So MGLKView now is a macOS class as well (the xcode project now can build both mac and iOS versions). So putting UIImage here is not going to be compiled on mac since it is iOS only class.

It is possible to change the return type to CGImage instead of UIImage to make it compilable on both iOS and mac. But honestly I think this feature could be moved outside MetalANGLE.framework. You can put it in your application code instead of inside MetalANGLE view. Since glReadPixels() can be called anywhere.

Anyway, may I know about the application you are working on. I’m very happy that MetalANGLE is helpful for your work.

@kakashidinho
Copy link
Owner

Close this as the new commit 1b9ddf75b has implemented this snapshot function for iOS. I decided to include this feature after noticing that the original Apple's GLKView also has it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants