Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate player data older than last_reset #210

Conversation

Slivo-fr
Copy link
Contributor

@Slivo-fr Slivo-fr commented Apr 6, 2022

This will prevent player with an old database to broadcast it to player that already performed their HS weekly reset

Related to #209

@Slivo-fr Slivo-fr changed the title Adds check on player last_checked, discard data older than last reset On received comms, adds check on player last_checked, discard data older than last reset Apr 6, 2022
@Slivo-fr Slivo-fr marked this pull request as draft April 6, 2022 13:38
@Slivo-fr Slivo-fr force-pushed the bugfix/discard-player-data-from-previous-week branch from 5838775 to 39a2d9b Compare April 6, 2022 13:41
@Slivo-fr Slivo-fr marked this pull request as ready for review April 6, 2022 13:41
@Slivo-fr Slivo-fr changed the title On received comms, adds check on player last_checked, discard data older than last reset Invalidate player data older than last_reset Apr 6, 2022
@Slivo-fr
Copy link
Contributor Author

Slivo-fr commented Apr 6, 2022

This check was existing prior to day1 player storing changes, partially restoring it back to discard players from past week

@Slivo-fr
Copy link
Contributor Author

Slivo-fr commented Apr 6, 2022

I would definitely include this one too before you release

@kakysha kakysha merged commit faa5ff3 into kakysha:classic Apr 7, 2022
@teelolws
Copy link
Contributor

teelolws commented Apr 7, 2022

@kakysha we have no further changes planned atm, can you tag a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants