Run test from php 5.4 to 8.3, and fix issues with php8.2 of dependencies #512
Conversation
set versions dynamically from currently really released php versions
and:
- apply a workaround for a bug with phpunit <= 6
- restore the Monkey patcher (which by default is commented out after having
run install.php)
- remove WelcomeTest.php
- exlude the full application/view dir from coverage
- fix void return type of setUp() with phpunit <= 6
Should also be done for:
PHPUnit\Framework\TestCase::setUpBeforeClass()
PHPUnit\Framework\TestCase::setUp()
PHPUnit\Framework\TestCase::assertPreConditions()
PHPUnit\Framework\TestCase::assertPostConditions()
PHPUnit\Framework\TestCase::tearDown()
PHPUnit\Framework\TestCase::tearDownAfterClass()
PHPUnit\Framework\TestCase::onNotSuccessfulTest()
See: https://phpunit.de/announcements/phpunit-7.html
Error was: str_replace(): Passing null to parameter #1 () of type array|string is deprecated
because with vaimo/composer-patches: - there is vaimo/composer-patches#115 which refrains from using it on php 7.0 7.1 & 7.2 - patching randomly fails with weird errors: Processing patches configuration - Applying patches for codeigniter/framework (2) ~ kalkun-sms/kalkun: patches/Codeigniter_Framework/v3.1.13/10-php82_support.patch [NEW] Add support for PHP 8.2 (part1) ~ kalkun-sms/kalkun: patches/Codeigniter_Framework/v3.1.13/10-php82_support-part2.patch [NEW] Add support for PHP 8.2 (part2) Error: Could not delete /home/runner/work/Kalkun/Kalkun/vendor/kenjis/ci-phpunit-test/CONTRIBUTING.md: In Filesystem.php line 288: Could not delete /home/runner/work/Kalkun/Kalkun/vendor/kenjis/ci-phpunit-t est/CONTRIBUTING.md: or Processing patches configuration - Applying patches for codeigniter/framework (2) ~ kalkun-sms/kalkun: patches/Codeigniter_Framework/v3.1.13/10-php82_support.patch [NEW] Add support for PHP 8.2 (part1) ~ kalkun-sms/kalkun: patches/Codeigniter_Framework/v3.1.13/10-php82_support-part2.patch [NEW] Add support for PHP 8.2 (part2) Error: Could not delete /home/runner/work/Kalkun/Kalkun/vendor/kenjis/ci-phpunit-test/.gitignore: In Filesystem.php line 288: Could not delete /home/runner/work/Kalkun/Kalkun/vendor/kenjis/ci-phpunit-t est/.gitignore:
Creation of dynamic property MY_Loader:: is deprecated
tenzap
changed the title
tenzap
force-pushed
the
feature-tests
branch
from
c5fa64e
to
5a4ebd9
Compare
| for minor in {0..20}; do | ||
| if dpkg --compare-versions ${major}.$minor le $upstream_ver && dpkg --compare-versions ${major}.$minor ge 5.6; then | ||
| PHP_VERSIONS+=("${major}.$minor") | ||
| fi | ||
| done | ||
| done |
There was a problem hiding this comment.
Is there any other simpler way to identify the versions? Maybe we could have fixed values that we support? My only concern is that is is a version released which is not supported, suddenly the CI would stop working, and throwing failure, even when other versions are supported.
There was a problem hiding this comment.
Is there any other simpler way to identify the versions?
I haven't found any other way using official input.
I prefer dynamic values, that's less maintenance burden and permits to identify when there is a problem with new releases.
About failing CI we could use something like this (mark some versions as non-experimental which would make fail, the other having continue_on_failure=true) ?
https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures
There was a problem hiding this comment.
Yes, this seems better. Stable version shouldn't fail and would get rightly reported
There was a problem hiding this comment.
What do you mean by stable version? The list would only contain released versions of PHP, not betas or devel versions.
There was a problem hiding this comment.
If we have only stable versions, then all good
| From fb1256a5b009b6264fbc85be44e0d97654d3fcd9 Mon Sep 17 00:00:00 2001 | ||
| From: George Petculescu <gxgpet@gmail.com> | ||
| Date: Sun, 6 Nov 2022 16:13:43 +0200 | ||
| Subject: [PATCH] Adding PHP 8.2 support | ||
|
|
||
| --- | ||
| .github/workflows/test-phpunit.yml | 20 +++++++++++++++++++- | ||
| system/core/Loader.php | 1 + |
There was a problem hiding this comment.
Instead of having patches here, can we refer to pr's on the upstream?
There was a problem hiding this comment.
PR content might be changing in good or bad. I prefer this approach.
There was a problem hiding this comment.
BTW there is not always a PR. Here there is, but for ci-phpunit-test, there isn't.
There was a problem hiding this comment.
Then maybe we should raise that to upstream?
There was a problem hiding this comment.
:D it comes from upstream... bcit-ci/CodeIgniter#6173
Really I'm not in favor or using PRs, it may change and therefore it would be difficult to find a bug from someone who installs kalkun with a "PR patch", the content of which is evolving in time.
A patch in a file is the best way to stay reproducible.
There was a problem hiding this comment.
oh you mean the other patch, bug is reported already. kenjis/ci-phpunit-test#413. I don't expect any change there unfortunately. Support seems to come to an end given the replies I get and the time that CI3 has been waiting for an update for recent PHP.
There was a problem hiding this comment.
Hmm, okay for now, we should probably also upgrade to ci4 then given no support for ci3 anymore?
|
Can I merge then? |
This will: