Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default property to sequence & closed captions #1506

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

erankor
Copy link
Contributor

@erankor erankor commented Jan 27, 2024

No description provided.

@aminvakil
Copy link

It works!

{
    "sequences": [
        {
            "clips": [
                {
                    "path": "/usr/share/nginx/html/multim3u8/once.mp4",
                    "type": "source"
                }
            ]
        },
        {
            "clips": [
                {
                    "path": "/usr/share/nginx/html/multim3u8/once.srt",
                    "type": "source"
                }
            ],
            "language": "en",
            "label": "English",
            "default": false
        }
    ]
}

results in:

#EXTM3U

#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subs0",NAME="English",LANGUAGE="en",AUTOSELECT=NO,DEFAULT=NO,URI="index-f2.m3u8"

#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=2335290,RESOLUTION=1920x800,FRAME-RATE=23.974,CODECS="avc1.640029,mp4a.40.2",SUBTITLES="subs0"
index-f1-v1-a1.m3u8

#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=166759,RESOLUTION=1920x800,CODECS="avc1.640029",URI="iframes-f1-v1-a1.m3u8"

@aminvakil
Copy link

FWIW I cherry-picked the commit from this branch and added to 1.32 tag and built nginx with it.

@erankor erankor merged commit 5b96c97 into master Jan 28, 2024
8 checks passed
@erankor erankor deleted the sequence-default-attr branch January 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants