FEM-2796 Added more details to LoadError and GeneralError #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GouravSna
commented
Jan 23, 2020
GouravSna
commented
- Added message to GeneralError and LoadError for PhoenixMediaProvider and KalturaOvpMediaProvider
- Removed redundant interface method from AndroidTest classes.
…r and KalturaOvpMediaProvider - Removed redundant interface method from AndroidTest classes.
giladna
reviewed
Jan 27, 2020
mediaproviders/src/main/java/com/kaltura/playkit/providers/ovp/KalturaOvpMediaProvider.java
Outdated
Show resolved
Hide resolved
GouravSna
changed the title
- Removed static ErrorElement function calls - Static import / import refactor
public static ErrorElement buildGeneralErrorElement(String message) {
return new ErrorElement(ErrorElement.GeneralError.getName(), message, ErrorElement.ErrorCode.GeneralErrorCode);
}
public static ErrorElement buildLoadErrorElement(String message) {
return new ErrorElement(ErrorElement.LoadError.getName(), message,ErrorElement.ErrorCode.LoadErrorCode);
}
public static ErrorElement buildNotFoundlErrorElement(String message) {
return new ErrorElement(ErrorElement.NotFound.getName(), message, ErrorElement.ErrorCode.NotFoundCode);
}
public static ErrorElement buildBadRequestErrorElement(String message) {
return new ErrorElement(ErrorElement.BadRequestError.getName(), message, ErrorElement.ErrorCode.BadRequestErrorCode);
}
public static ErrorElement buildGeneralErrorElement(String message) {
return new ErrorElement(ErrorElement.GeneralError.getName(), message, ErrorElement.ErrorCode.GeneralErrorCode);
}
public static ErrorElement buildLoadErrorElement(String message) {
return new ErrorElement(ErrorElement.LoadError.getName(), message,ErrorElement.ErrorCode.LoadErrorCode);
}
public static ErrorElement buildNotFoundlErrorElement(String message) {
return new ErrorElement(ErrorElement.NotFound.getName(), message, ErrorElement.ErrorCode.NotFoundCode);
}
public static ErrorElement buildBadRequestErrorElement(String message) {
return new ErrorElement(ErrorElement.BadRequestError.getName(), message, ErrorElement.ErrorCode.BadRequestErrorCode);
}
noamtamim
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.