Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11144): Casting doesn't work if you stop it and re-initiate #55

Merged
merged 3 commits into from
Apr 12, 2021
Merged

fix(FEC-11144): Casting doesn't work if you stop it and re-initiate #55

merged 3 commits into from
Apr 12, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 11, 2021 •
edited
Loading

Description of the Changes

Happens since IS_CONNECTED listener removed on destroy of the first session, so no listener is existing to initiate the next session.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested review from OrenMe and yairans April 11, 2021 13:23
@dan-ziv dan-ziv self-assigned this Apr 11, 2021
yairans
yairans previously approved these changes Apr 11, 2021
View reviewed changes
OrenMe
OrenMe previously approved these changes Apr 11, 2021
View reviewed changes
@dan-ziv dan-ziv dismissed stale reviews from OrenMe and yairans via e9fefe8 April 11, 2021 15:39
@dan-ziv dan-ziv merged commit 2530aab into master Apr 12, 2021
@dan-ziv dan-ziv deleted the FEC-11144 branch April 12, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe OrenMe left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-ziv @OrenMe @yairans