fix(FEC-11156): cast button appears for one player only when multiple players configured on the page and casting failed #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2021
yairans
reviewed
Oct 11, 2021
src/cast-player.js
Outdated
| @@ -60,6 +60,7 @@ class CastPlayer extends BaseRemotePlayer { | |||
| }; | |||
|
|
|||
| static _isAvailable: boolean = false; | |||
| static _loadPromise: any = null; | |||
There was a problem hiding this comment.
Suggested change
| static _loadPromise: any = null; | |
| static _loadPromise: ?Promise<void> = null; |
yairans
previously approved these changes
Nov 16, 2021
yairans
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Prevent calling CastLoader.load when multiple players are loaded one after the other
Distinguish between a casting and a non-casting player
Fixes FEC-11156
Related PRs:
kaltura/kaltura-player-js#495
kaltura/playkit-js-ui#640
CheckLists