Merge pull request #8 from kaltura/patch-warning-slate

fix: lint and types
kaltura · Oct 12, 2023 · 0ed3a76 · 0ed3a76
2 parents 7562a8c + bff5a39
commit 0ed3a76
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 12 deletions.
diff --git a/.github/workflows/run_canary.yaml b/.github/workflows/run_canary.yaml
@@ -17,6 +17,6 @@ jobs:
     uses: kaltura/playkit-js-common/.github/workflows/canary_plugin.yaml@master
     secrets: inherit
     with:
-      schema-type: "playerV3Versions"
-      node-version: "18.x"
+      schema-type: 'playerV3Versions'
+      node-version: '18.x'
       tests-yarn-run-to-execute: 'build lint:check types:check'
diff --git a/demo/index.html b/demo/index.html
@@ -4,8 +4,8 @@
     <meta charset="UTF-8" />
     <title>Slate Plugin</title>
     <script src="https://unpkg.com/@playkit-js/kaltura-player-js@latest/dist/kaltura-ovp-player.js"></script>
-<!--    <script src="https://unpkg.com/@playkit-js/playkit-js-slate@latest/dist/playkit-slate.js"></script>-->
-<!--    for dev -->
+    <!--    <script src="https://unpkg.com/@playkit-js/playkit-js-slate@latest/dist/playkit-slate.js"></script>-->
+    <!--    for dev -->
     <script src="../playkit-slate.js"></script>
   </head>
   <body>
@@ -21,9 +21,9 @@
         // translations - for local environment
         ui: {
           translations: {
-            "en": {
-              "slate": {
-                "dismiss": "Dismiss"
+            en: {
+              slate: {
+                dismiss: 'Dismiss'
               }
             }
           }

diff --git a/src/index.ts b/src/index.ts
@@ -1,5 +1,6 @@
 import { registerPlugin } from '@playkit-js/kaltura-player-js';
 import { pluginName, SlatePlugin } from './slate-plugin';
 
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 registerPlugin(pluginName, SlatePlugin);
diff --git a/src/slate-plugin.tsx b/src/slate-plugin.tsx
@@ -6,7 +6,7 @@ import { SlateEventTypes } from './types/slate-event-types';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import { FakeEvent } from '@playkit-js/playkit-js';
-import {SlateConfig} from "./types/slate-config";
+import { SlateConfig } from './types/slate-config';
 
 export const pluginName = 'slate';
 
@@ -19,7 +19,7 @@ export class SlatePlugin extends BasePlugin<SlateConfig> {
     imageOnMediaLoad: '',
     titleOnMediaLoad: '',
     messageOnMediaLoad: '',
-    dismissTextOnMediaLoad: 'Dismiss',
+    dismissTextOnMediaLoad: 'Dismiss'
   };
 
   constructor(name: string, player: KalturaPlayer, config: SlateConfig) {
@@ -41,8 +41,11 @@ export class SlatePlugin extends BasePlugin<SlateConfig> {
     });
   }
 
-  public loadMedia() {
-    if (this.player.sources.metadata?.tags?.toString().includes(SLATE_PRE_ROLL_TAG) && (this.config.titleOnMediaLoad || this.config.messageOnMediaLoad)) {
+  public loadMedia(): void {
+    if (
+      this.player.sources.metadata?.tags?.toString().includes(SLATE_PRE_ROLL_TAG) &&
+      (this.config.titleOnMediaLoad || this.config.messageOnMediaLoad)
+    ) {
       this.slateManager.add({
         title: this.config.titleOnMediaLoad,
         message: this.config.messageOnMediaLoad,

diff --git a/tsconfig.json b/tsconfig.json
@@ -23,4 +23,4 @@
   },
   "include": ["src/**/*.ts", "cypress/**/*.ts"],
   "exclude": ["node_modules"]
-}
+}