Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEV-1550): Player v7 | info v3.1.0-canary.7-c284265 | Accessibility | Space doesn't work for the X button inside info plugin. #698

Closed
wants to merge 1 commit into from
Closed

fix(FEV-1550): Player v7 | info v3.1.0-canary.7-c284265 | Accessibility | Space doesn't work for the X button inside info plugin. #698

wants to merge 1 commit into from

Conversation

Tzipi-kaltura
Copy link
Contributor

Description of the Changes

add option to close the button also with the space key.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura
fix(FEV-1550): Player v7 | info v3.1.0-canary.7-c284265 | Accessibili…
529918e 
…ty | Space doesn't work for the X button inside info plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladna giladna giladna approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tzipi-kaltura @giladna