Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat(UIKIT-1280,ui,MenuItem): Добавлен тултип для заблокированных элементов #910

Merged
merged 5 commits into from
May 15, 2024

Conversation

Cabagemage
Copy link
Contributor

…ванных элементов

Чеклист

  • Написать тесты для реализованного функционала
  • Описать jsdoc для экспортируемых функций, компонентов
  • Описать jsdoc для props экспортируемых компонентов
  • Реализовать или обновить storybook для компонента
  • Проверить код на соответствие style guide
  • Запросить ревью у дизайнера, если был изменен ui или создан новый компонент

Copy link
Contributor

@mfrolov89 mfrolov89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Стоит добавить в сторибук для MenuItem кейс с disabled

packages/components/src/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
packages/components/src/MenuItem/MenuItem.tsx Show resolved Hide resolved
@mfrolov89 mfrolov89 changed the title feat(UIKIT-1280,ui,MenuItem): MenuItem. Добавить тултип для заблокированных элементов feat(UIKIT-1280,ui,MenuItem): Добавлен тултип для заблокированных элементов Apr 17, 2024
@Cabagemage Cabagemage requested a review from mfrolov89 May 3, 2024 11:33
packages/components/src/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
packages/components/src/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
@mfrolov89 mfrolov89 requested review from Kostayne and removed request for AndTem May 7, 2024 10:35
@Cabagemage Cabagemage enabled auto-merge (squash) May 14, 2024 07:38
@Cabagemage Cabagemage disabled auto-merge May 14, 2024 07:39
@Cabagemage Cabagemage merged commit 7cfd46e into main May 15, 2024
8 of 11 checks passed
@Cabagemage Cabagemage deleted the feat/UIKIT-1280-1 branch May 15, 2024 13:52
Copy link
Contributor

🎉 This PR is included in version 3.118.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 3.118.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants