Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat(UIKIT-1076,ui,Description): Добавлена возможность копирования текста #913

Merged
merged 18 commits into from
Apr 11, 2024

Conversation

Kostayne
Copy link
Contributor

@Kostayne Kostayne commented Apr 8, 2024

Чеклист

  • Написать тесты для реализованного функционала
  • Реализовать или обновить storybook для компонента
  • Проверить код на соответствие style guide

@Kostayne Kostayne requested review from mfrolov89 and a team as code owners April 8, 2024 13:51
@Kostayne Kostayne requested a review from AndTem April 8, 2024 13:51
@Kostayne Kostayne removed the request for review from AndTem April 8, 2024 14:12
Copy link
Contributor

@mfrolov89 mfrolov89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Иконка должна быть частью строки, ховер должен срабатывать при наведении на эту строку, сейчас у тебя текст отдельно, иконка отдельно
  2. При наведении у текста должно быть подчеркивание
  3. Курсор должен менять состояние на pointer
  4. Отступ между иконкой и текстом не соответсвует макету

@Kostayne Kostayne requested a review from mfrolov89 April 9, 2024 09:33
@Kostayne Kostayne requested a review from mfrolov89 April 9, 2024 13:42
@mfrolov89 mfrolov89 changed the title feat(UIKIT-1076,ui,Description): Добавлена фича копирования текста feat(UIKIT-1076,ui,Description): Добавлена возможность копирования текста Apr 9, 2024
@@ -87,6 +151,21 @@ export const JustifyContent = () => {
);
};

export const JustifyContentCanCopy = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const JustifyContentCanCopy = () => {
export const JustifyContentWithCanCopy = () => {

либо можно показать этот пример в рамках JustifyContent, тут на твое усмотрение

packages/components/src/Description/Value/Value.tsx Outdated Show resolved Hide resolved
packages/components/src/Description/Value/Value.tsx Outdated Show resolved Hide resolved
packages/components/src/Description/Value/styles.ts Outdated Show resolved Hide resolved
@Kostayne Kostayne requested a review from mfrolov89 April 10, 2024 10:15
@Kostayne Kostayne requested a review from mfrolov89 April 10, 2024 12:22
@mfrolov89 mfrolov89 merged commit 6efe166 into main Apr 11, 2024
8 of 11 checks passed
@mfrolov89 mfrolov89 deleted the feat/UIKIT-1076 branch April 11, 2024 07:51
Copy link
Contributor

🎉 This PR is included in version 3.106.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants