This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
feat(UIKIT-1076,ui,Description): Добавлена возможность копирования текста #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrolov89
suggested changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Иконка должна быть частью строки, ховер должен срабатывать при наведении на эту строку, сейчас у тебя текст отдельно, иконка отдельно
- При наведении у текста должно быть подчеркивание
- Курсор должен менять состояние на pointer
- Отступ между иконкой и текстом не соответсвует макету
mfrolov89
suggested changes
Apr 9, 2024
mfrolov89
changed the title
feat(UIKIT-1076,ui,Description): Добавлена фича копирования текста
feat(UIKIT-1076,ui,Description): Добавлена возможность копирования текста
Apr 9, 2024
mfrolov89
suggested changes
Apr 10, 2024
@@ -87,6 +151,21 @@ export const JustifyContent = () => { | |||
); | |||
}; | |||
|
|||
export const JustifyContentCanCopy = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
export const JustifyContentCanCopy = () => { | |
export const JustifyContentWithCanCopy = () => { |
либо можно показать этот пример в рамках JustifyContent, тут на твое усмотрение
mfrolov89
suggested changes
Apr 10, 2024
mfrolov89
approved these changes
Apr 10, 2024
🎉 This PR is included in version 3.106.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Чеклист