-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the build instructions to match the new version #128
Comments
I managed to build it with |
Thanks for the notice. I insist on the fact that what's not on the I just updated the README and the CHANGELOG. |
Since I do a lot of testing lately with Shaarli, my CI is building the latest commits. I only build manually when either Arthur or you fix one of the relevant issues, so athough I'm on bleeding edge, my Shaarli is fairly stable until some new fix comes out that I'm interested in. This morning, I reconfigured something else in my CI that involved a rerun of the pipeline, and so I observed it broke. I'm not familiar with rollup and their docs seemed to be extensive, and they have lots of command line flags, that's why I reported it. Then I got the idea, maybe you also use some flags that you don't want to forget, and maybe created a build script for that, that's when I found the npm script later. So I accidentally found this change, and not by following all commits all the time 😃 |
No worries and again, thanks for your strong testing, you're helping me a lot :) I just want to ensure you know that I sometimes don't push everything at the same time and that branches other than master remain somehow experimental. When working on a big feature that I need to split over several days, I still prefer to push at least once a day even if things aren't perfect. |
Please update the build instructions (https://github.com/kalvn/Shaarli-Material/tree/support-v012#build-for-production) as it seems outdated since da29c7c
At first, I was not aware of the change, so I tried to install the missing gulp locally but then it said no gulpfile, so I checked the commits, and it seems there was a change with the build tool.
The text was updated successfully, but these errors were encountered: