sqlops: Increase size of static escape buffer #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assumes that all characters require escaping and the maximum input string length right now is 1023. When the ss7ops module is used the length of a IAM is longer than this. Increase the static buffer to 8k. This increases the memory usage of each process by 7168 bytes.
|
Maybe making the size a modparam and allocating the buffer in mod_init will make it more flexible and easier to tune for larger buffer needs. |
|
Alternative implementation pushed to master branch. |
|
Sorry, I didn't notice the feedback and just rebased my branch. Yes. Your approach to make it runtime configurable is a lot better! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumes that all characters require escaping and the
maximum input string length right now is 1023. When the ss7ops
module is used the length of a IAM is longer than this. Increase
the static buffer to 8k. This increases the memory usage of each
process by 7168 bytes.