Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make final field accessible too #91

Merged
merged 1 commit into from
May 15, 2019
Merged

Make final field accessible too #91

merged 1 commit into from
May 15, 2019

Conversation

Kevinrob
Copy link
Contributor

R8 make "final" some fields that are never set.

I can't use proguard-android-optimize.txt because of it.
-allowaccessmodification is causing issue with Kotlin data-class.

@Kevinrob
Make final field accessible too.
f00c8d6 
R8 make "final" some fields that are never set.
@coveralls
Copy link

coveralls commented Feb 21, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 81.906% when pulling f00c8d6 on Kevinrob:fix_R8_acces_optimization into 17a5616 on kamikat:master.

@Kevinrob
Copy link
Contributor Author

@kamikat Can you take a look at this?

@kamikat kamikat merged commit 2cd5a56 into kamikat:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kevinrob @coveralls @kamikat