Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong examples in the README #156

Closed
MarcoVigna17 opened this issue May 27, 2020 · 5 comments
Closed

Wrong examples in the README #156

MarcoVigna17 opened this issue May 27, 2020 · 5 comments
Assignees
Milestone

Comments

@MarcoVigna17
Copy link

I'm struggling to follow the examples in the README because I can't relate them to the package actual implementation:

  1. breaker.BreakBySignal as long as the other breakers don't implement the strategy.Breaker interface (the Err() method is missing). This is also a problem in the implementation, that is backing me from using this breaker

  2. The function (second parameter of retry.Do) must accept a context as parameter. This is not reflected in the documentation

@kamilsk kamilsk self-assigned this May 27, 2020
@kamilsk
Copy link
Owner

kamilsk commented May 27, 2020

Hi, @MarcoVigna17! Thanks for the report.

The function (second parameter of retry.Do) must accept a context as parameter. This is not reflected in the documentation

Yes, sorry for that, v5 is still unstable (the latest version is v5.0.0-rc5), and I didn't sync the readme. I fix that soon.

About the first point: I have an issue with an update of the interface, and it is partially implemented.

So, I can suggest using:

  1. retry/v4 together with breaker any version
  2. retry/v5-rc together with breaker/v1.2-rc

@kamilsk kamilsk added this to the retry 5.0 milestone May 27, 2020
@kamilsk
Copy link
Owner

kamilsk commented May 27, 2020

I added the Err() method to the breakers here.

@MarcoVigna17
Copy link
Author

Thanks for the feedback @kamilsk.

I will try what you suggested today

kamilsk added a commit that referenced this issue May 29, 2020
@kamilsk
Copy link
Owner

kamilsk commented May 29, 2020

@MarcoVigna17 I updated the readme and added information about breaker compatibility here
7a5261c

@kamilsk
Copy link
Owner

kamilsk commented May 30, 2020

I close the issue but feel free to reopen it if needed.

@kamilsk kamilsk closed this as completed May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants