-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong examples in the README #156
Comments
Hi, @MarcoVigna17! Thanks for the report.
Yes, sorry for that, v5 is still unstable (the latest version is v5.0.0-rc5), and I didn't sync the readme. I fix that soon. About the first point: I have an issue with an update of the interface, and it is partially implemented. So, I can suggest using:
|
I added the Err() method to the breakers here. |
Thanks for the feedback @kamilsk. I will try what you suggested today |
@MarcoVigna17 I updated the readme and added information about |
I close the issue but feel free to reopen it if needed. |
I'm struggling to follow the examples in the README because I can't relate them to the package actual implementation:
breaker.BreakBySignal
as long as the other breakers don't implement thestrategy.Breaker
interface (theErr()
method is missing). This is also a problem in the implementation, that is backing me from using this breakerThe function (second parameter of
retry.Do
) must accept a context as parameter. This is not reflected in the documentationThe text was updated successfully, but these errors were encountered: