Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the extracted Kanela file after exiting #1036

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion bundle/kamon-bundle/src/main/scala/kamon/bundle/Bundle.scala
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ package kamon.bundle

import java.lang.management.ManagementFactory
import java.nio.file.{Files, StandardCopyOption}

import net.bytebuddy.agent.ByteBuddyAgent
import org.slf4j.LoggerFactory

import scala.util.control.NonFatal

object Bundle {

Expand Down Expand Up @@ -49,6 +51,16 @@ object Bundle {
withInstrumentationClassLoader(springBootClassLoader.orNull) {
ByteBuddyAgent.attach(temporaryAgentFile.toFile, pid())
}

try {
temporaryAgentFile.toFile.deleteOnExit()
} catch {
case NonFatal(t) =>
// We initialize the logger here instead of as a static member to avoid loading
// Logger-related classes before attaching Kanela to the current JVM.
LoggerFactory.getLogger(Bundle.getClass)
.warn("Failed to mark the temporary Kanela Agent file for deletion after exiting the JVM", t)
}
}
}

Expand Down