Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sbt: Publish kamon-pekko and kamon-pekko-http artifacts #1291

Merged
merged 1 commit into from
Oct 3, 2023
Merged

build.sbt: Publish kamon-pekko and kamon-pekko-http artifacts #1291

merged 1 commit into from
Oct 3, 2023

Conversation

pronovic
Copy link
Contributor

@pronovic pronovic commented Aug 17, 2023

Thanks for adding support for Pekko and Pekko HTTP. I'm in the process of converting some of my own code from Akka to Pekko, and I wanted to do some local testing with the new Kamon functionality before v2.7.0 was released.

However, build.sbt does not seem to publish the new artifacts. I'm not 100% confident that I understand the builld process here, but I think these adjustments are what is needed. With this in place, I can do sbt +clean +compile +publishM2 and get the Pekko artifacts in ~/.m2 so I can use them to test my other libraries and services.

If I've misunderstood something here, I'm happy to make changes and resubmit.

@pronovic
Copy link
Contributor Author

@DieBauer just wanted you to be aware of this change.

@TjarkoG
Copy link
Contributor

TjarkoG commented Sep 6, 2023

we'd love a release for kamon-pekko

@nvollmar
Copy link
Contributor

@ivantopo would be great to get that in

Copy link
Contributor

@hughsimpson hughsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hughsimpson hughsimpson merged commit 8a1502e into kamon-io:master Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants