Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective-C with xcodebuild doesn't integrate with top-level Makefile #105

Closed
hborders opened this issue Nov 10, 2015 · 1 comment
Closed

Comments

@hborders
Copy link

Root Makefile Diff:

diff --git a/Makefile b/Makefile
index 29ac249..37b370f 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,8 @@ mal_TEST_OPTS = --start-timeout 60 --test-timeout 120

 IMPLS = awk bash c clojure coffee cpp crystal cs erlang elixir es6 factor forth fsharp go groovy \
        guile haskell java julia js kotlin lua make mal ocaml matlab miniMAL nim \
-       perl php ps python r racket rpython ruby rust scala swift vb vimscript
+       perl php ps python r racket rpython ruby rust scala swift vb vimscript \
+       objc

 step0 = step0_repl
 step1 = step1_read_print
@@ -104,6 +105,7 @@ swift_STEP_TO_PROG =   swift/$($(1))
 vb_STEP_TO_PROG =      vb/$($(1)).exe
 vimscript_STEP_TO_PROG = vimscript/$($(1)).vim
 guile_STEP_TO_PROG =   guile/$($(1)).scm
+objc_STEP_TO_PROG =    objc/DerivedData/mal/Build/Products/Debug/$($(1))

 # Needed some argument munging
 COMMA = ,
@@ -155,6 +157,7 @@ vb_RUNSTEP =      mono ../$(2) --raw $(3)
 vimscript_RUNSTEP = ./run_vimscript.sh ../$(2) $(3)
 # needs TERM=dumb to work with readline
 guile_RUNSTEP =   guile --no-auto-compile -L ../guile ../$(2) $(3)
+objc_RUNSTEP =    ../$(2) $(3)


 vimscript_TEST_OPTS = --test-timeout 30

objc/Makefile:

DerivedData/mal/Build/Products/Debug/step0_repl: step0_repl/main.m
    xcodebuild -scheme step0_repl -configuration Debug -derivedDataPath DerivedData/mal

I get the following output from make test^objc^step0

$ make test^objc^step0
/Applications/Xcode7.1.app/Contents/Developer/usr/bin/make -C objc/DerivedData/mal/Build/Products/Debug/ step0_repl
make: *** objc/DerivedData/mal/Build/Products/Debug/: No such file or directory.  Stop.
make: *** [objc/DerivedData/mal/Build/Products/Debug/step0_repl] Error 2

If I built with Xcode (which creates the same binary as make would), I then get the following output from make test^objc^step0

$ make test^objc^step0
/Applications/Xcode7.1.app/Contents/Developer/usr/bin/make -C objc/DerivedData/mal/Build/Products/Debug/ step0_repl
make: *** objc/DerivedData/mal/Build/Products/Debug/: No such file or directory.  Stop.
make: *** [objc/DerivedData/mal/Build/Products/Debug/step0_repl] Error 2
LT-A8-120617:mal heath.borders$ make test^objc^step0
----------------------------------------------
Testing test^objc^step0, step file: objc/DerivedData/mal/Build/Products/Debug/step0_repl, test file: tests/step0_repl.mal
Running: ../runtest.py   ../tests/step0_repl.mal -- ../objc/DerivedData/mal/Build/Products/Debug/step0_repl 
Testing basic string
TEST: abcABC123 -> ['',abcABC123] -> SUCCESS
Testing string containing spaces
TEST: hello mal world -> ['',hello mal world] -> SUCCESS
Testing string containing symbols
TEST: []{}"'* ;:() -> ['',[]{}"'* ;:()] -> SUCCESS
Test long string
TEST: hello world abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ 0123456789 (;:() []{}"'* ;:() []{}"'* ;:() []{}"'*) -> ['',hello world abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ 0123456789 (;:() []{}"'* ;:() []{}"'* ;:() []{}"'*)] -> SUCCESS
TEST RESULTS (for ../tests/step0_repl.mal):
    0: soft failing tests
    0: failing tests
    4: passing tests
    4: total tests

I'm not blocked because I can build from Xcode and then run the tests from make, but I won't be able to issue a pull request until I can build entirely within the make infrastructure.

@hborders hborders changed the title Objective-C with xcodebuild doesn't integrate well with top-level Makefile Objective-C with xcodebuild doesn't integrate with top-level Makefile Nov 10, 2015
hborders pushed a commit to hborders/mal that referenced this issue Nov 10, 2015
make doesn't work yet. Filed an issue:
kanaka#105
@kanaka kanaka closed this as completed in f045aba Nov 18, 2015
@kanaka
Copy link
Owner

kanaka commented Nov 18, 2015

Okay, I think I found and fixed the problem. Let me know if that addresses it for you.

micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants