Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New LaTeX3 implementation #639

Merged
merged 5 commits into from
Aug 8, 2024
Merged

New LaTeX3 implementation #639

merged 5 commits into from
Aug 8, 2024

Conversation

asarhaddon
Copy link
Contributor

It requires two cosmetic changes to existing tests.

Copy link
Owner

@kanaka kanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the time-ms test change (comment inline), looks really good. You'll also need to add it to IMPLS.yml for CI to pick it up.

impls/tests/stepA_mal.mal Outdated Show resolved Hide resolved
Copy link
Owner

@kanaka kanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it failed during image build due to the tzdata interactivity issue. This should fix it:

-RUN apt-get -y install texlive-latex-base
+RUN DEBIAN_FRONTEND=noninteractive apt-get -y install texlive-latex-base

Implementation looks great. I love that we'll have another document rendering language (postscript, xslt). Do you recall how long this took you?

@asarhaddon
Copy link
Contributor Author

I cannot remember exactly, but I spent at least a week in cumulated time.
I was expecting a challenge. LaTeX3 is an effort to make TeX/LaTeX as consistent as possible, despite its original design (Knuth did explicitly not want TeX to be Turing-complete). The recommend way to implement LaTeX extensions is to use the embedded LUA interpreter.
That said, the LaTeX3 documentation is wonderful and clearly describes its purpose and limitations.
I cannot reproduce the issue locally. On my machine the texlive-latex-base package is at version 2024.20240706-1, while the version in the build logs is 2019-*. I will try to require ubuntu:24.04 instead of 20.04 in the Dockerfile.

@kanaka kanaka merged commit 205cf51 into kanaka:master Aug 8, 2024
110 of 111 checks passed
@kanaka
Copy link
Owner

kanaka commented Aug 8, 2024

Guess the latex in 20.04 was just too old.

@asarhaddon asarhaddon deleted the latex3 branch August 8, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants