-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New LaTeX3 implementation #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the time-ms test change (comment inline), looks really good. You'll also need to add it to IMPLS.yml
for CI to pick it up.
Never require quotes around the symbol.
Self hosting fails at step4 because of exceeded TeX capacity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it failed during image build due to the tzdata interactivity issue. This should fix it:
-RUN apt-get -y install texlive-latex-base
+RUN DEBIAN_FRONTEND=noninteractive apt-get -y install texlive-latex-base
Implementation looks great. I love that we'll have another document rendering language (postscript, xslt). Do you recall how long this took you?
I cannot remember exactly, but I spent at least a week in cumulated time. |
Guess the latex in 20.04 was just too old. |
It requires two cosmetic changes to existing tests.