Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dd-trace-go sql tracer #34

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Support dd-trace-go sql tracer #34

merged 3 commits into from
Oct 3, 2024

Conversation

winebarrel
Copy link
Member

@winebarrel winebarrel commented Oct 3, 2024 •
edited
Loading

@winebarrel winebarrel marked this pull request as ready for review October 3, 2024 04:43
kazukousen
kazukousen reviewed Oct 3, 2024
View reviewed changes
util.go Outdated
err := conn.Raw(func(driverConn any) error {
var stdlibConn *stdlib.Conn

if tracedConn, ok := driverConn.(*sqltracer.TracedConn); ok {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wConn, ok := driverConn.(interface { WrappedConn() driver.Conn }); ok みたいにインターフェイスだけ持ってくるのはどうですか？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正してみました57b94f5

@winebarrel
Copy link
Member Author

🙏

@winebarrel winebarrel merged commit d45c478 into master Oct 3, 2024
2 checks passed
@winebarrel winebarrel deleted the support_datadog branch October 3, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazukousen kazukousen kazukousen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winebarrel @kazukousen