Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/saplings devops #159

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Update/saplings devops #159

merged 4 commits into from
Feb 14, 2024

Conversation

paulsheldrake
Copy link
Contributor

@paulsheldrake paulsheldrake commented Feb 13, 2024

Ticket: https://kanopi.teamwork.com/app/tasks/29421361

Updates the default circleci and docksal setup to assume we're using the saplings_child theme.

  • Updates node version and cypress version for cypress tests.
  • Remove storybook steps from circleci
  • Updates compile theme step to use a PHP image that installs the version of node we need so we can do a composer install to get the theme dependencies at the PHP level as well.
  • Updates PHP version to match pantheon.yml in pantheon deploy step

Working compile -> deployment: https://app.circleci.com/pipelines/github/kanopi/saplings-devops/12/workflows/a6da8aaf-6e19-4998-8e95-4b514736e767

Notes:

  • saplings_child theme doesn't work with aggregation turned on. fixing this is out of scope of this ticket
  • the cypress tests run but currently fail. fixing this is out of scope of this ticket

@paulsheldrake paulsheldrake marked this pull request as draft February 13, 2024 14:45
@paulsheldrake paulsheldrake marked this pull request as ready for review February 13, 2024 21:37
@thejimbirch thejimbirch merged commit 0bf4f36 into main Feb 14, 2024
@thejimbirch thejimbirch deleted the update/saplings-devops branch February 14, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants