Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Breaking change for Emit between v8.3.0 and v8.4.1 #316

Closed
SaphuA opened this issue Apr 15, 2020 · 1 comment
Closed

Breaking change for Emit between v8.3.0 and v8.4.1 #316

SaphuA opened this issue Apr 15, 2020 · 1 comment

Comments

@SaphuA
Copy link

SaphuA commented Apr 15, 2020

This used to work in v8.3.0, but is now broken in v8.4.1.

    // Upload.vue
    @Emit("onUploadSuccess") public onUploadSuccess(fileName: string, response?: any) {}

    private logic() {
        this.onUploadSuccess("HelloWorld.xlsx", response);
    }

    // SomeComponent.vue
    <Upload @onUploadSuccess="onUploadSuccess" />

    private onUploadSuccess(fileName: string, response: any) {
        // ... It breaks here. The arguments are now wrapped in an array instead.
    }
@SaphuA SaphuA changed the title Breaking change for Emit Breaking change for Emit between v8.3.0 and v8.4.1 Apr 15, 2020
@tomliebl
Copy link

Proposed fix is here: #306

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants