This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Vue typing issue solved #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because vue was in the dependencies, when installed into a project that has modified Vue type it does inherit from the package installed of Vue type instead of project-modified instance. This causes type errors and prevents proper usage. This solution comes from what the official vue-class-component package is doing.
|
Hi. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this package is used in a project that has a modified Vue type (like using i18n or so), the decorators of this project give error because the output type is not matching (it does pick the vue package installed inside the package folder).
With this change the decorator inherits the type from the project instead of the local one and thus not giving any error.
This solution comes from what the official vue-class-component package is doing.
https://github.com/vuejs/vue-class-component/blob/master/package.json#L65