Make it work under SSR #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI. Thanks for your PR. I haven't tried SSR yet, but I understand its importance. 👍 |
kaorun343
reviewed
Sep 29, 2017
src/index.js
Outdated
| @@ -2,33 +2,35 @@ import { getIdFromURL, getTimeFromURL } from './utils' | |||
| import container from './container' | |||
| import YouTubePlayer from './player' | |||
|
|
|||
| export { YouTubePlayer, getIdFromURL, getTimeFromURL } | |||
| export default { YouTubePlayer, getIdFromURL, getTimeFromURL, | |||
There was a problem hiding this comment.
Please revert the way of exporting.
This change is not necessary for the improvements, I think.
|
Hey @kaorun343, I moved it back to your original style on the export. I also rebuilt and bumped the nom version. Thanks for taking a look! |
|
Thanks! I'll merge this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy;
I used some simple detection for global
window&documentobjects to short-circuit attempts to make the video play when using server-side rendering under Vue.js 2.xThis is working for us currently, and tests are still passing. Let me know if you would like further changes or do not like this approach.
Also - I didn't bump the
package.json, so that might have to happen if you accept the PR and want to bump the version and publish to NPM.Thanks!