Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gltf_auto_export): fix animation export #148

Merged
merged 7 commits into from
Feb 29, 2024
Merged

fix(gltf_auto_export): fix animation export #148

merged 7 commits into from
Feb 29, 2024

Conversation

kaosat-dev
Copy link
Owner

@kaosat-dev kaosat-dev commented Feb 27, 2024 •
edited
Loading

  • fix(gltf_auto_export): added fix for correct "deep-copying" of objects & hierarchy so that animated
    meshes & nested hierarchies get exported correctly
  • test(gltf_auto_export):
    • added visual testing to check for overall regression :
      • added screenshoting in bevy app
      • added visual compare with reference screenshot on python side
    • added testing of correct export of animated models
    • added testing of correct export of empties
    • added testing of correct export of nested hierarchies
    • added testing of correct export of blueprints, with & without components etc
  • fixes gltf_auto_export v0.13, does not export animated objects correctly #147

@kaosat-dev
test():
4c06ffd 
 * added animated model in test blend file
 * added simple hierarchy blueprint in test blend file
 * on the bevy side:
  * added animation detection
  * added generation of a json diagnostics file to enable writing data from the Bevy side to be
checked on the python/blender tests side
 * on the Blender side:
   * added missing animation export setting
   * added checking for diagnostics file info
@kaosat-dev
fix(gltf_auto_export): added possible fix & experimentations for
ae8824c 
correct "deep-copying" of objects & hierarchy so that animated
 meshes also get exported correctly
@kaosat-dev
tests(gltf_auto_export):
90cd478 
 * fleshed out testing some more, checking for nested data etc
 * added visual testing to check for overall regression :
  * added screenshoting in bevy app
  * added visual compare with reference screenshot on python side
* also fixed issue in export of animations
* related tweaks & improvements
@kaosat-dev
chore(): cargo fmt
c6ae833
@kaosat-dev
chore(): removed accidently added files
27baeba
@kaosat-dev
test(auto_export): added testing of correct export of empties
62248e5
@kaosat-dev
chore(): cleanups
44ca8f1
@kaosat-dev kaosat-dev marked this pull request as ready for review February 29, 2024 14:22
@kaosat-dev kaosat-dev merged commit 7ffcd55 into main Feb 29, 2024
2 checks passed
@janhohenheim
Copy link
Contributor

Works like a charm now on Foxtrot main!

@kaosat-dev
Copy link
Owner Author

Works like a charm now on Foxtrot main!

Awesome !
Did you manage to heal the poor fox ?

@janhohenheim
Copy link
Contributor

Yeah, I imported your GLTF from the examples and somehow that worked 😅

@kaosat-dev kaosat-dev deleted the gltf_auto_export_fix_animation_export branch March 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gltf_auto_export v0.13, does not export animated objects correctly
2 participants
@kaosat-dev @janhohenheim