Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change dates to numbers when serializing #6

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

hofmeister
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Oct 18, 2023

KAP-1526 [BUG] DSL type date is not parsed in React/TS language target

The date type in our DSL translates to a javascript Date in our React/TS language target. But we do not parse the response to JS dates so they are actually strings. So the type doesn't match what we get from the api client.

blocks/chat-app/src/entities/Message.ts :

//
// GENERATED SOURCE - DO NOT EDIT
//

export interface Message {
    id: string;
    text: string;
    createdAt: Date;
    authorId: string;
}

A message from the api client:

image (3).png

@hofmeister hofmeister merged commit c321c7f into master Oct 18, 2023
1 check passed
@hofmeister hofmeister deleted the KAP-1526 branch October 18, 2023 10:55
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
## [1.1.2](v1.1.1...v1.1.2) (2023-10-18)

### Bug Fixes

* Change dates to numbers when serializing ([#6](#6)) ([c321c7f](c321c7f))
@kapeta-bot
Copy link

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants