Add seek_by method
#462
Merged
Add seek_by method
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable using only the needed parameters and remove the need to create an Rdkafka Message which is an implementation wrapper that should not be needed for the API of the clients
mensfeld
requested changes
Jun 19, 2024
|
Thanks. This change aligns well with the nature of the lib (low level) as it actually provides lower level API than the one already existing :) |
mensfeld
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable using only the needed parameters and remove the need to provide or create a fake
Rdkafka::Consumer::Messagewhich is an implementation wrapper that should not be needed for the API of the clients when callingseek.It is my humble opinion that providing this alternative can give a cleaner interface for the clients to use, however I'm happy to receive feedback or change it in case there is something I might be missing.
The specs I added are based on the existing specs of the
seekmethod.PS to the maintainers: Thanks for your work, this is a great library ❤️