hid: Support sending & retrieving feature reports #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverpanic
added a commit
to neverpanic/co2monitor
that referenced
this pull request
Mar 4, 2018
Only Linux has a hidraw driver providing file-based access to HID devices. For other operating systems such as Windows or macOS, USB HID devices must be accessed through a library. Depend on karalabe/hid (with karalabe/hid#13 merged) for USB communication. This also removes the necessity to manually specify the correct hidraw device file, since HIDAPI can do enumeration based on the USB vendor ID and product ID. This also simplifies supporting multiple devices with a single server process, so implement that. Note that all CO2 detectors I could get a hold had non-unique serial numbers, so the device serial number could not be used to distinguish them in the prometheus output. Instead, the path of the USB device is used now. Unfortunately this means that the sensor ID changes when the detector is plugged into a different USB port. Also note that these paths can get very large and contain special characters and spaces, but prometheus does not allow these in gauge identifiers. To work around this, apply SHA1 to the path and use it as identifier.
|
I tested just the SendFeatureReport() on a Win10 and it also works |
|
@neverpanic, great work! @karalabe maybe it's time to merge this PR? |
gballet
suggested changes
May 24, 2019
hid_enabled.go
Outdated
| // sure to allow space for this extra byte in []b. Upon return, the first byte | ||
| // will still contain the Report ID, and the report data will start in b[1]. | ||
| func (dev *Device) GetFeatureReport(b []byte) (int, error) { | ||
| // Abort if nothing to read |
There was a problem hiding this comment.
Please make this comment more accurate: there might be something to read, it's simply that there is no provided space to copy it to.
Some USB devices require sending a feature report before they will answer to read requests. Implement wrapper functions for the hidapi hid_send_feature_report and hid_get_feature_report functions to support doing so.
neverpanic
force-pushed
the
support-feature-reports
branch
from
757d6c8
to
6d68e5b
Compare
|
Anything still blocking this? |
|
@karalabe I hope this doesn't come across as offensive, it's really not meant that way. If you just don't have the time for it currently, I'll understand. But since I'm depending on this library with a project, I'm wondering: are you still planning to maintain this library or shall we concentrate on a fork? |
fjl
approved these changes
Aug 6, 2019
|
Sorry for the delay. |
|
Thank you! |
trinode
added a commit
to trinode/hid
that referenced
this pull request
Aug 20, 2021
This reverts commit 9c14560.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some USB devices require sending a feature report before they will answer to read requests. Implement wrapper functions for the hidapi hid_send_feature_report and hid_get_feature_report functions to support doing so.
I have tested this on macOS.
Note that this is only my second time writing Go, so please pull with review and care.
See also #10.