implement ReadTimeout
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to perform a read with a specified timeout
ocraviotto
pushed a commit
to ocraviotto/hid
that referenced
this pull request
Dec 28, 2020
The original Read() method was a wrapper to C.hid_read. C.hid_read checks for the device blocking field to pass a timeout value to C.hid_read_timeout accordingly: if blocking is enabled, -1, else 0. The changed introduced in karalabe#22 and merged in this fork breaks that and incorrectly assumes that a 0 timeout means a blocking read. This commit allows to maintain the original use of Read() while also allowing a package user to make use of ReadTimeout(b, t) ReadTimeout() was previously missing from hid_disable.go
ocraviotto
pushed a commit
to ocraviotto/hid
that referenced
this pull request
Dec 28, 2020
The original Read() method was a wrapper to C.hid_read. C.hid_read checks for the device blocking field to pass a timeout value to C.hid_read_timeout accordingly: if blocking is enabled, -1, else 0. The changed introduced in karalabe#22 and merged in this fork breaks that and incorrectly assumes that a 0 timeout means a blocking read. This commit allows to maintain the original use of Read() while also allowing a package user to make use of ReadTimeout(b, t) ReadTimeout() was previously missing from hid_disable.go
ocraviotto
pushed a commit
to ocraviotto/hid
that referenced
this pull request
Dec 28, 2020
The original Read() method was a wrapper to C.hid_read. C.hid_read checks for the device blocking field to pass a timeout value to C.hid_read_timeout accordingly: if blocking is enabled, -1, else 0. The changed introduced in karalabe#22 and merged in this fork breaks that and incorrectly assumes that a 0 timeout means a blocking read. This commit allows to maintain the original use of Read() while also allowing a package user to make use of ReadTimeout(b, t) ReadTimeout() was previously missing from hid_disable.go
ocraviotto
added a commit
to ocraviotto/hid
that referenced
this pull request
Dec 28, 2020
The original Read() method was a wrapper to C.hid_read. C.hid_read checks for the device blocking field to pass a timeout value to C.hid_read_timeout accordingly: if blocking is enabled, -1, else 0. The changed introduced in karalabe#22 and merged in this fork breaks that and incorrectly assumes that a 0 timeout means a blocking read. This commit allows to maintain the original use of Read() while also allowing a package user to make use of ReadTimeout(b, t) ReadTimeout() was previously missing from hid_disable.go
ocraviotto
added a commit
to ocraviotto/hid
that referenced
this pull request
Dec 28, 2020
The original Read() method was a wrapper to C.hid_read. C.hid_read checks for the device blocking field to pass a timeout value to C.hid_read_timeout accordingly: if blocking is enabled, -1, else 0. The changed introduced in karalabe#22 and merged in this fork breaks that and incorrectly assumes that a 0 timeout means a blocking read. This commit allows to maintain the original use of Read() while also allowing a package user to make use of ReadTimeout(b, t) ReadTimeout() was previously missing from hid_disable.go
This was referenced Feb 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to perform a read with a specified timeout
Note: This is the same as #11, I just implemented it slightly different. I don't really care which one is used just wanted to give the option to the maintainer.