Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean way to stop netty server instead of killing process #411

Closed
ptrthomas opened this issue Jun 5, 2018 · 1 comment
Closed

clean way to stop netty server instead of killing process #411

ptrthomas opened this issue Jun 5, 2018 · 1 comment
Assignees
@ptrthomas
Labels
enhancement fixed
Milestone
v0.8.0

Comments

@ptrthomas
Copy link
Member

as reported by @Hanwen196 here: #402 (comment)

on windows it was troublesome to stop the netty / mock server cleanly.

proposal is to auto expose a /__admin/stop endpoint where a simple GET would stop things.
@ptrthomas ptrthomas added this to the v0.8.0 milestone Jun 5, 2018
@ptrthomas ptrthomas self-assigned this Jun 5, 2018
ptrthomas added a commit that referenced this issue Jun 14, 2018
@ptrthomas
implemented http stop hook for server #411
1340f37
@ptrthomas
Copy link
Member Author

released 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrthomas ptrthomas

Labels
enhancement fixed
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
1 participant
@ptrthomas