add support for NTLM authentication #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for NTLM authentication through the ApacheHttpClient implementation. It takes advantage of the default AuthSchemeRegistry that the builder creates when none is supplied, which includes support for NTLM. And so, supplying the NT credentials and target auth scheme will activate it within the http client from the config.
Unfortunately, the tests are quite limited since a true test would require an environment with an LDAP setup and a system configured with NTLM auth. I couldn't find anything readily available to support that, so I have only included a test for configuring NTLM within a Karate script and tested it against a valid NTLM system within my org locally.