Fix No Integer restore in G61 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Fixes the case where no Integers were specified on the G61 command: ``` G60 G0 X100 Y100 Z20 G61 X Y ``` does not return to the last location as : ``` G60 G0 X100 Y100 Z20 G61 X0 Y0 ``` does. this matches what the spec says: https://marlinfw.org/docs/gcode/G061.html which does not even document you can put an integer after the axis letters.
The vyper board need a file name which begin with 'main_board_'
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
force-pushed
the
karcaw-fix-g61
branch
2 times, most recently
from
9568ce5
to
85a84cc
Compare
thinkyhead
force-pushed
the
karcaw-fix-g61
branch
from
85a84cc
to
4bc093f
Compare
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes the case where no Integers were specified on the G61 command:
does not return to the last location as :
does. this matches what the spec says:
https://marlinfw.org/docs/gcode/G061.html
which does not even document you can put an integer after the axis letters.
Description
Fix for MarlinFirmware#26222
Requirements
No
Benefits
G61 will work according to the spec.
Configurations
Related Issues
(MarlinFirmware#26222)