-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 revision #3
Python3 revision #3
Conversation
MichaelCurrie
commented
Sep 7, 2017
- Increment version to 0.1.1
- Remove .pyc and .DS_Store files, and add .gitignore file
- Make a few changes to the code (like putting parentheses around the print statements) to make the repo compatible with both Python 2 and Python 3
Also add a .gitignore file to prevent it from happening again
It seems this project is dead. This PR is out there a while now. I am also interested in a python 3 version of this. Was adding parentheses the only real change needed for converting to 3? If this project is really dead, perhaps it is worth forking and releasing a new version on pypi? |
I just emailed Karim to see if he'll accept the PR. If you hear nothing in another few days, I'd say it's a great idea to do what you suggest! It wasn't just adding parentheses, if you check the changelog, there were other small things like changing
to
|
My apologies for this (very) late reply, haven't had as much time for these projects in the last year, but hope to have more time going forward forward. Accepted the PR now, and I do appreciate the contribution! |
thanks @karimbahgat! I know how that goes. Are you also planning on doing a pypi release? |
Yes, that's a good idea. Will do, but I just tried running the test file (which itself needs updating) on Py2.7 and got a weird non-exception print statement saying 'Iterator is not an iterator' and empty result. Will have to look at fixing this before updating pypi. Any idea what it might be? |
The simplest way to fix that is to |
Found the error, and had to change some additional things too. Tested that it now works on both Py 2 and 3. |
Officially updated as v1.0 from pypi: https://pypi.org/project/Pytess/. |