Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 revision #3

Merged
merged 4 commits into from
Aug 7, 2018
Merged

Conversation

MichaelCurrie
Copy link
Contributor

  • Increment version to 0.1.1
  • Remove .pyc and .DS_Store files, and add .gitignore file
  • Make a few changes to the code (like putting parentheses around the print statements) to make the repo compatible with both Python 2 and Python 3

Michael Currie added 4 commits September 7, 2017 15:01
@ahopkins
Copy link

ahopkins commented Aug 2, 2018

It seems this project is dead. This PR is out there a while now.

I am also interested in a python 3 version of this. Was adding parentheses the only real change needed for converting to 3?

If this project is really dead, perhaps it is worth forking and releasing a new version on pypi?

@MichaelCurrie
Copy link
Contributor Author

I just emailed Karim to see if he'll accept the PR.

If you hear nothing in another few days, I'd say it's a great idea to do what you suggest!

It wasn't just adding parentheses, if you check the changelog, there were other small things like changing

for sitepoint,polyedges in poly_dict.items():

to

for sitepoint,polyedges in list(poly_dict.items()):

@karimbahgat karimbahgat merged commit 7186656 into karimbahgat:master Aug 7, 2018
@karimbahgat
Copy link
Owner

My apologies for this (very) late reply, haven't had as much time for these projects in the last year, but hope to have more time going forward forward. Accepted the PR now, and I do appreciate the contribution!

@ahopkins
Copy link

ahopkins commented Aug 7, 2018

thanks @karimbahgat! I know how that goes. Are you also planning on doing a pypi release?

@karimbahgat
Copy link
Owner

Yes, that's a good idea. Will do, but I just tried running the test file (which itself needs updating) on Py2.7 and got a weird non-exception print statement saying 'Iterator is not an iterator' and empty result. Will have to look at fixing this before updating pypi. Any idea what it might be?

@MichaelCurrie
Copy link
Contributor Author

MichaelCurrie commented Aug 7, 2018

The simplest way to fix that is to import six and then throw an if statement around the two or so lines I actually had to change that were not just print statements, restoring the old python code for version 2.7. I will try to do this tmrw if I have time and make a PR or else you guys can try... :)

@karimbahgat
Copy link
Owner

Found the error, and had to change some additional things too. Tested that it now works on both Py 2 and 3.

@karimbahgat
Copy link
Owner

Officially updated as v1.0 from pypi: https://pypi.org/project/Pytess/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants