Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Porter Stemming Algorithm #13

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Conversation

greenat92
Copy link
Collaborator

Hi @kariminf,
This PR for #12, Needs reviewing, All tests are passed as well.

To validate this implementation,I rely largely on these resources:

  1. Porter Stemming Algorithm
  2. Porter stemmer pure js Implementation

Copy link
Owner

@kariminf kariminf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job (y)

As for stemmer choice, It will be a little more different, like:

var EnMorpho = JsLingua.getService("Morpho", "eng");
var morpho = new EnMorpho();

morpho.setStemmer("PorterStemmer");
var stem = morpho.stem("extraordinary");

I'll do it since some changes have to be made on the parent lass

@kariminf kariminf merged commit 99f2f56 into kariminf:master Jul 31, 2017
@greenat92
Copy link
Collaborator Author

greenat92 commented Jul 31, 2017

@kariminf , i have problem of rebasing sorry , i'll fix it as soon as

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants